revert "keep cursor visible when size changes" since it breaks things

2006-06-26  Michael Natterer  <mitch@imendio.com>

	* gtk/gtktextview.c (gtk_text_view_size_allocate): revert "keep
	cursor visible when size changes" since it breaks things (#344874).

diff --git a/ChangeLog b/ChangeLog
index c609acee5dd22b3a34dae6eeaf25d61acb7a9ab3..21c8a4e4941655b16fa2067bcd4797525d764c86 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2006-06-26  Michael Natterer  <mitch@imendio.com>
+
+       * gtk/gtktextview.c (gtk_text_view_size_allocate): revert "keep
+       cursor visible when size changes" since it breaks things (#344874).
+
 2006-06-26  Matthias Clasen  <mclasen@redhat.com>
 
        * gtk/gtkcombobox.c (gtk_cell_view_menu_item_new): Avoid

diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10
index c609acee5dd22b3a34dae6eeaf25d61acb7a9ab3..21c8a4e4941655b16fa2067bcd4797525d764c86 100644 (file)
--- a/ChangeLog.pre-2-10
+++ b/ChangeLog.pre-2-10
@@ -1,3 +1,8 @@
+2006-06-26  Michael Natterer  <mitch@imendio.com>
+
+       * gtk/gtktextview.c (gtk_text_view_size_allocate): revert "keep
+       cursor visible when size changes" since it breaks things (#344874).
+
 2006-06-26  Matthias Clasen  <mclasen@redhat.com>
 
        * gtk/gtkcombobox.c (gtk_cell_view_menu_item_new): Avoid

diff --git a/gtk/gtktextview.c b/gtk/gtktextview.c
index ae55bc8e852c0d388a3dac14238a87de8e14d351..45c250ccab1d95c4eade386dbf0edc534ec5cdc5 100644 (file)
--- a/gtk/gtktextview.c
+++ b/gtk/gtktextview.c
@@ -3127,21 +3127,11 @@ gtk_text_view_size_allocate (GtkWidget *widget,
    */
   gtk_text_view_flush_first_validate (text_view);
 
+  /* widget->window doesn't get auto-redrawn as the layout is computed, so has to
+   * be invalidated
+   */
   if (size_changed && GTK_WIDGET_REALIZED (widget))
-    {
-      GtkTextBuffer *buffer;
-
-      /* widget->window doesn't get auto-redrawn as the layout is
-       * computed, so has to be invalidated
-       */
-      gdk_window_invalidate_rect (widget->window, NULL, FALSE);
-
-      /* keep cursor visible */
-      buffer = get_buffer (text_view);
-      gtk_text_view_scroll_to_mark (text_view,
-                                    gtk_text_buffer_get_mark (buffer, "insert"),
-                                    0.0, FALSE, 0.0, 0.0);
-    }
+    gdk_window_invalidate_rect (widget->window, NULL, FALSE);
 }
 
 static void